June 08, 2011

SF State Drupal Theme and CSS cleanup


Below are a list of recent theme patches submitted to SF State Drupal:
  1. Skip navigation link added to theme
  2. Webtemplate stylesheet conflicts removed from sfsu.info (defaults.css and system.css)
  3. Redundant styles from custom.css removed
With the default Drupal styles removed, the nav menu items, tables, and lists should now appear as intended by the SF State Web Template Program.

Big up to Nat Supakit from the SF State Drupal team for pushing these patches through.

Webtemplate CSS patch


I also submitted a patch for a layout bug in the global.css. The Web Team needs to approve it, but in the meantime, this is the local stylesheet override I'm using:

#main .brief {float:none;overflow:hidden;}

To replicate the bug:
  1. Create a page where the main column has more content than the nav or sidebar.
  2. Apply the .brief class to the last div element within the #main div.
What should happen is that the float will cause the main column to extend past the nav and sidebar columns.

My proposed fix is to get rid of the float and add an overflow:

-- #main .brief {width:100%; float:left; padding-top:10px; border-top:1px dotted #ddcc77;}

++ #main .brief {width:100%; overflow:hidden; padding-top:10px; border-top:1px dotted #ddcc77;}

Disqus for Passing the Word